Skip to content

http2: reduce usage of public require('util') in core.js #26789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

http2: reduce usage of public require('util') in core.js #26789

wants to merge 2 commits into from

Conversation

@Naturalclar
Copy link
Contributor

@Naturalclar Naturalclar commented Mar 19, 2019

This PR is part of issue #26546

Replaced usage of public require('util')

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Mar 19, 2019
@joyeecheung joyeecheung mentioned this pull request Mar 20, 2019
Closed
@BridgeAR
Copy link
Member

BridgeAR commented Mar 22, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/21771/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2019
@joyeecheung joyeecheung mentioned this pull request Mar 22, 2019
Closed
@BridgeAR
Copy link
Member

BridgeAR commented Mar 22, 2019

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21792/

@BridgeAR
Copy link
Member

BridgeAR commented Mar 24, 2019

@Naturalclar seems like there are some conflicts. Would you be so kind and rebase this to resolve them and to force push afterwards? Thanks!

@BridgeAR BridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 24, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Mar 25, 2019 •
edited
Loading

@Naturalclar oh, thanks for your PR first, but I'm sorry to say that this seems to be duplicated with #26784 (which was landed already)

@BridgeAR
Copy link
Member

BridgeAR commented Mar 25, 2019

@Naturalclar thanks for the PR and sorry that this can not land. As @ZYSzys pointed out this already landed in Node.js as two PRs were working on the same file.

Please keep up the good work!

@BridgeAR BridgeAR closed this Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@shisama shisama shisama approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Naturalclar @BridgeAR @ZYSzys @jasnell @shisama @nodejs-github-bot