Skip to content

lib: switch to internalBinding for cjs loader #23492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DrakiaXYZ wants to merge 2 commits into from
Closed

lib: switch to internalBinding for cjs loader #23492

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9baf5e7
lib: switch to internalBinding for cjs loader
DrakiaXYZ Oct 12, 2018
60c58d3
Remove unneeded !! as getOptions returns a bool
DrakiaXYZ Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ const {
stripBOM,
stripShebang
} = require('internal/modules/cjs/helpers');
const preserveSymlinks = !!process.binding('config').preserveSymlinks;
const preserveSymlinksMain = !!process.binding('config').preserveSymlinksMain;
const experimentalModules = !!process.binding('config').experimentalModules;
const options = internalBinding('options');
const preserveSymlinks = !!options.getOptions('--preserve-symlinks');
Copy link
Member

@devsnek devsnek Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no need for the !! here, as options.getOptions already returns true/false

Copy link
Contributor Author

@DrakiaXYZ DrakiaXYZ Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the !! in a second commit. I wasn't sure whether I should or not, as they were there for the old code. Thanks!

const preserveSymlinksMain = !!options.getOptions('--preserve-symlinks-main');
const experimentalModules = !!options.getOptions('--experimental-modules');

const {
ERR_INVALID_ARG_TYPE,
Expand Down