doc: add missing options for crypto sign.sign() #22824
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
crypto
Contributor
|
CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/867/ сс @nodejs/crypto |
lpinca
approved these changes
Sep 12, 2018
jasnell
approved these changes
Sep 12, 2018
tniessen
added
the
author ready
richardlau
approved these changes
Sep 13, 2018
Trott
reviewed
Sep 13, 2018
| * `privateKey` {string | Object} | ||
| - `key` {string} | ||
| - `passphrase` {string} | ||
| - `padding` {integer} |
Member
There was a problem hiding this comment.
I know it seems sensible to keep key and passphrase near each other, but I wonder if we would be best to alphabetize the options always. Especially in crypto, the options lists can get long and having a clear and obvious ordering is helpful when you're looking for that one option you care about.
Member
targos
pushed a commit
that referenced
this pull request
Sep 17, 2018
Fixes: #22813 PR-URL: #22824 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 18, 2018
Fixes: #22813 PR-URL: #22824 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 19, 2018
Fixes: #22813 PR-URL: #22824 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2018
Fixes: #22813 PR-URL: #22824 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22813
Checklist