Skip to content

lib: refactor variable declarations #22643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

lib: refactor variable declarations #22643

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ab244a
lib: refactor variable declarations
ZYSzys Sep 1, 2018
41d2f70
lib: change == to ===
ZYSzys Sep 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/internal/fs/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,14 +112,14 @@ for (const name of Reflect.ownKeys(Dirent.prototype)) {
}

function copyObject(source) {
Copy link
Contributor

@GrosSacASac GrosSacASac Sep 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Object.assign ?

Copy link
Member

@addaleax addaleax Sep 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’d probably want to benchmark that first

Copy link
Member

@jasnell jasnell Sep 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not likely to be much slower than for-in to be honest. /cc @bmeurer

Copy link
Member Author

@ZYSzys ZYSzys Sep 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this even a bit faster ?

Copy link
Member

@bmeurer bmeurer Sep 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recent versions of V8 should have fast Object.assign().

var target = {};
for (var key in source)
const target = {};
for (const key in source)
target[key] = source[key];
return target;
}

function getDirents(path, [names, types], callback) {
var i;
let i;
if (typeof callback == 'function') {
const len = names.length;
let toFinish = 0;
Expand Down