Skip to content

src: fix --without-ssl build #22484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: fix --without-ssl build #22484

wants to merge 1 commit into from

Conversation

@ianloic
Copy link
Contributor

@ianloic ianloic commented Aug 23, 2018

ProcessArgv referenced fields on PerProcessOptions that aren't there
when the build is configured --without-ssl.

Checklist

@ianloic
src: fix --without-ssl build
f204c79 
ProcessArgv referenced fields on PerProcessOptions that aren't there
when the build is configured --without-ssl.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 23, 2018
@refack refack added process Issues and PRs related to the process subsystem. regression Issues related to regressions. fast-track PRs that do not need to wait for 48 hours to land. labels Aug 23, 2018
@refack
Copy link
Contributor

refack commented Aug 23, 2018

We (the Build WG) should add ./configure --without-ssl to the build matrix.

Please 👍 for fast tracking this resolution of a regression.

@refack refack mentioned this pull request Aug 23, 2018
Closed
2 tasks
@addaleax addaleax added the cli Issues and PRs related to the Node.js command line interface. label Aug 23, 2018
@addaleax
Copy link
Member

addaleax commented Aug 23, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16699/

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed process Issues and PRs related to the process subsystem. labels Aug 23, 2018
@refack
Copy link
Contributor

refack commented Aug 23, 2018 •
edited
Loading

Resume https://ci.nodejs.org/job/node-test-commit/20844/

@addaleax
Copy link
Member

addaleax commented Aug 23, 2018

Landed in 1146067, thanks for the PR! 🎉

@addaleax addaleax closed this Aug 23, 2018
addaleax pushed a commit that referenced this pull request Aug 23, 2018
@ianloic @addaleax
src: fix --without-ssl build
1146067 
ProcessArgv referenced fields on PerProcessOptions that aren't there
when the build is configured --without-ssl.

PR-URL: #22484
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Aug 28, 2018
@ianloic @addaleax
src: fix --without-ssl build
6395b35 
ProcessArgv referenced fields on PerProcessOptions that aren't there
when the build is configured --without-ssl.

PR-URL: #22484
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Sep 3, 2018
@ianloic @targos
src: fix --without-ssl build
034ba73 
ProcessArgv referenced fields on PerProcessOptions that aren't there
when the build is configured --without-ssl.

PR-URL: #22484
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@ianloic @targos
src: fix --without-ssl build
e5d47c4 
ProcessArgv referenced fields on PerProcessOptions that aren't there
when the build is configured --without-ssl.

PR-URL: #22484
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. cli Issues and PRs related to the Node.js command line interface. fast-track PRs that do not need to wait for 48 hours to land. regression Issues related to regressions.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ianloic @refack @addaleax @jasnell @cjihrig @richardlau @nodejs-github-bot