Skip to content

doc: update iojs.1 for man page #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yosuke-furukawa wants to merge 1 commit into from
Closed

doc: update iojs.1 for man page #2204

yosuke-furukawa wants to merge 1 commit into from

Conversation

@yosuke-furukawa
Copy link
Member

@yosuke-furukawa yosuke-furukawa commented Jul 19, 2015

I checked man iojs but some options are missing like (--trace-sync-io, --strong_mode).
so I just updated iojs.1.

Trott
Trott reviewed Jul 19, 2015
View reviewed changes
doc/iojs.1 Outdated
Copy link
Member

@Trott Trott Jul 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: fetaures -> features

@yosuke-furukawa
Copy link
Member Author

yosuke-furukawa commented Jul 19, 2015

@Trott Thanks. I will fix.

these options are generated by v8... I will try to report or pull request to v8.
https://github.com/nodejs/io.js/blob/master/deps/v8/src/flag-definitions.h#L180

@targos
Copy link
Member

targos commented Jul 19, 2015

@yosuke-furukawa I already did a CL about that a while ago.
It is here but was never reviewed.
@bnoordhuis maybe you know what I should do to summon a reviewer?

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Jul 19, 2015
@targos
Copy link
Member

targos commented Jul 19, 2015

LGTM btw

Fishrock123
Fishrock123 reviewed Jul 19, 2015
View reviewed changes
doc/iojs.1 Outdated
Copy link
Contributor

@Fishrock123 Fishrock123 Jul 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I/O?

@Fishrock123
Copy link
Contributor

Fishrock123 commented Jul 19, 2015

Had been meaning to do this. LGTM otherwise.

@Fishrock123
Copy link
Contributor

Fishrock123 commented Jul 19, 2015

Had been meaning to do this also. LGTM minus the comment

@Fishrock123
Copy link
Contributor

Fishrock123 commented Jul 20, 2015

@yosuke-furukawa LGTM :)

thefourtheye
thefourtheye reviewed Jul 22, 2015
View reviewed changes
doc/iojs.1 Outdated
Copy link
Contributor

@thefourtheye thefourtheye Jul 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listed twice with different default values.

Copy link
Member Author

@yosuke-furukawa yosuke-furukawa Jul 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooops, this is also v8 document mistake....

https://github.com/v8/v8-git-mirror/blob/05ec0ff08381b3780195069250f658da6040f131/src/flag-definitions.h#L644-L647

@yosuke-furukawa
Copy link
Member Author

yosuke-furukawa commented Jul 23, 2015

fixed! PTAL @thefourtheye

thefourtheye
thefourtheye reviewed Jul 23, 2015
View reviewed changes
doc/iojs.1
Copy link
Contributor

@thefourtheye thefourtheye Jul 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overapproximate weak closer or overapproximate weak closure?

@thefourtheye
Copy link
Contributor

thefourtheye commented Jul 23, 2015

@yosuke-furukawa Sorry, I couldn't complete the review the other day. I left two more comments now. PTAL. LGTM 👍

@Fishrock123
Copy link
Contributor

Fishrock123 commented Jul 23, 2015

I wouldn't worry about reviewing the v8 options too much. They'll probably just be overwritten in the future anyways.

@yosuke-furukawa
Copy link
Member Author

yosuke-furukawa commented Jul 23, 2015

Yes, I agree @Fishrock123 .

I just output these options using d8 --help.
We don't need to correct these options directly.

https://github.com/v8/v8-git-mirror/blob/master/src/flag-definitions.h#L635-L636
https://github.com/v8/v8-git-mirror/blob/4.2.77/src/flag-definitions.h#L811

@silverwind
Copy link
Contributor

silverwind commented Aug 17, 2015

LGTM

@yosuke-furukawa I guess you can land it after an rebase.

@yosuke-furukawa
Copy link
Member Author

yosuke-furukawa commented Aug 18, 2015

@silverwind Thank you!

@evanlucas
Copy link
Contributor

evanlucas commented Sep 18, 2015

Looks like the --trace-sync-io option is still not in the man page. The v8 options appear to have been updated though. Do we want to rebase this?

@yosuke-furukawa
Copy link
Member Author

yosuke-furukawa commented Sep 18, 2015

I feel this man page should be generated automatically. I will close this and I will send another PR ASAP.

@UbuntuEvangelist UbuntuEvangelist mentioned this pull request Dec 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@yosuke-furukawa @targos @Fishrock123 @thefourtheye @silverwind @evanlucas @Trott @mscdex