Skip to content

fs: fix options.end of fs.ReadStream() #18121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MoonBall wants to merge 4 commits into from
Closed

fs: fix options.end of fs.ReadStream() #18121

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
036b29b
fs: fix options.end of fs.ReadStream()
Jan 12, 2018
1981fbf
fs: fix options.end of fs.ReadStream()
Jan 13, 2018
609404f
Modify code style of the test
Jan 13, 2018
3723635
Move the test cast to test-fs-read-stream.js
Jan 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2236,7 +2236,8 @@ function ReadStream(path, options) {
this.flags = options.flags === undefined ? 'r' : options.flags;
this.mode = options.mode === undefined ? 0o666 : options.mode;

this.start = options.start;
this.start = typeof this.fd !== 'number' && options.start === undefined ?
0 : options.start;
this.end = options.end;
this.autoClose = options.autoClose === undefined ? true : options.autoClose;
this.pos = undefined;
Expand Down
13 changes: 13 additions & 0 deletions test/sequential/test-stream2-fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,16 @@ w.on('results', function(res) {
});

r.pipe(w);

const optionsEnd = 3;
Copy link
Contributor

@cjihrig cjihrig Jan 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write this like:

{
  // Verify that end works when start is not specified.
  const end = 3;
  const r = new FSReadable(file, { end });
  const w = new TestWriter();

  w.on('results', common.mustCall((res) => {
    assert.strictEqual(w.length, end + 1);
  }));

  r.pipe(w);
}

Copy link
Member Author

@MoonBall MoonBall Jan 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

const optionsEndExpectLength = optionsEnd + 1;
const rOfEnd = new FSReadable(file, {
end: optionsEnd,
});
const wOfEnd = new TestWriter();

wOfEnd.on('results', function(res) {
assert.strictEqual(wOfEnd.length, optionsEndExpectLength);
});

rOfEnd.pipe(wOfEnd);