Skip to content

test: replace common.fixturesDir with fixtures #15946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AshleyRayMaceli wants to merge 2 commits into from
Closed

test: replace common.fixturesDir with fixtures #15946

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f736f6e
replace common.fixturesDir with fixtures
AshleyRayMaceli Oct 6, 2017
e2533a4
update to fixtures.readKey
AshleyRayMaceli Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/parallel/test-http2-https-fallback.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

const common = require('../common');
const fixtures = require('../common/fixtures');

if (!common.hasCrypto)
common.skip('missing crypto');
Expand All @@ -17,7 +18,7 @@ const { connect: tls } = require('tls');
const countdown = (count, done) => () => --count === 0 && done();

function loadKey(keyname) {
return readFileSync(join(common.fixturesDir, 'keys', keyname));
return readFileSync(join(fixtures.fixturesDir, 'keys', keyname));
Copy link
Contributor

@pawelgolda pawelgolda Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be using method fixtures.readKey to get the keys.

}

const key = loadKey('agent8-key.pem');
Expand Down