libs: remove redundant RegExp parts

[vsemozhetbyt]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

dns, repl

If I get this correctly, a RegExp part with a quantifier '0 or more' is redundant if:

• it is used at the very beginning or the very end of the RegExp;
• it is used in a boolean context (test());
• or it is not captured in match()/exec() results (full or partial) or does not affect match indices.

However, these parts may improve readability and comprehensibility. If this is the case for the changed fragments, feel free to reject this PR.

Also, I can miss some other nuances, so, please, correct me.

[vsemozhetbyt]

CI: https://ci.nodejs.org/job/node-test-pull-request/8529/

[mscdex]

Also may as well change this to a regex.test() since the return value is discarded.

[fhalde]

just depth would be fine instead of depth: depth

[vsemozhetbyt]

This seems to be the object of another PR. But I recall that some collaborators oppose partial shorthands: this is preferred to be consistent, all shorthands or all full pairs.

[mscdex]

I wouldn't worry about this for this PR.

[fhalde]

@vsemozhetbyt Didn't know about the guideline :p I had a review in my PR for shorthand that's why!

[vsemozhetbyt]

It is not a guideline yet, just a comment in some PR or proposition that I recall)

[vsemozhetbyt]

The first CI was green.

I've replaced match() with test() in a boolean context as was proposed.

New CI: https://ci.nodejs.org/job/node-test-pull-request/8530/

1 flaky test fails on arm, seems unrelated.

[Trott]

Micro-nit: Might be better as /\bfunction\b/ or /\sfunction\s/?

[vsemozhetbyt]

Done)

[vsemozhetbyt]

Nit addressed. CI: https://ci.nodejs.org/job/node-test-pull-request/8533/

[vsemozhetbyt]

Sorry, it seems I have a bit wider PR emerging, so I will close this for now, as it will interweave with the new one.

[vsemozhetbyt]

Absorbed by #13536