Skip to content

v7.x Backport - build: avoid passing kill empty input in Makefile #12337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gibfahn wants to merge 1 commit into from
Closed

v7.x Backport - build: avoid passing kill empty input in Makefile #12337

gibfahn wants to merge 1 commit into from

Conversation

@gibfahn
Copy link
Member

@gibfahn gibfahn commented Apr 11, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v7.x labels Apr 11, 2017
@gibfahn gibfahn mentioned this pull request Apr 11, 2017
Merged
2 tasks
@gibfahn
build: avoid passing kill empty input in Makefile
dc78812 
Using `xargs -r` on some platforms and `xargs` on others doesn't work,
we can't guarantee whether xargs is GNU or not. Avoid the issue by only
running kill if there are processes to clean.

PR-URL: nodejs#12158
@gibfahn gibfahn force-pushed the xargs-makefile-v7.x branch from f300f8d to dc78812 Compare May 22, 2017 22:55
@gibfahn
Copy link
Member Author

gibfahn commented May 22, 2017

CI: https://ci.nodejs.org/job/node-test-commit/10079/

@gibfahn
Copy link
Member Author

gibfahn commented Jun 3, 2017

@nodejs/release should I land this myself? Not sure of the procedure here.

@evanlucas
Copy link
Contributor

evanlucas commented Jun 3, 2017

I'd say go for it :]

@gibfahn
Copy link
Member Author

gibfahn commented Jun 3, 2017 •
edited
Loading

Just realised that we probably won't be doing another v7.x, so might as well just close.

Thanks anyway @evanlucas !

@gibfahn gibfahn closed this Jun 3, 2017
@gibfahn gibfahn deleted the xargs-makefile-v7.x branch June 3, 2017 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gibfahn @evanlucas @richardlau @nodejs-github-bot