Skip to content

test: changed test1 of test-vm-timeout.js so that entire error message would be matched #11590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
moe-dizzle wants to merge 3 commits into from
Closed

test: changed test1 of test-vm-timeout.js so that entire error message would be matched #11590

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50fe4f0
test: changed test1 of test-vm-timeout.js so that entire error messag…
moe-dizzle Feb 27, 2017
9fad978
test: changed test1 of test-vm-timeout.js so that entire error messag…
moe-dizzle Feb 27, 2017
4412ae2
made solution more succinct
moe-dizzle Feb 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/parallel/test-vm-timeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ const vm = require('vm');
// Test 1: Timeout of 100ms executing endless loop
assert.throws(function() {
vm.runInThisContext('while(true) {}', { timeout: 100 });
}, function(err) {
Copy link
Contributor

@mscdex mscdex Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using a regexp as the second argument would be more succinct: /^Error: Script execution timed out\.$/

Copy link
Contributor Author

@moe-dizzle moe-dizzle Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha I agree with you before when I tried /^Script execution timed out.$/ it didn't work, so I did the above approached. I didn't realize that "Error: " was included also. Awesome I will correct it!

const re = /^Script execution timed out\.$/;
if ((err instanceof Error) && re.test(err.message)) { return true; }
});

// Test 2: Timeout must be >= 0ms
Expand Down