Skip to content

test: Fix flaky test-vm-timeout-rethrow #11530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kunalspathak wants to merge 3 commits into from
Closed

test: Fix flaky test-vm-timeout-rethrow #11530

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
247d487
test: Fix flaky test-vm-timeout-rethrow
kunalspathak Feb 24, 2017
b0907c0
test: Removed unnecessary function
kunalspathak Feb 24, 2017
f1a5b63
test: More refactoring
kunalspathak Feb 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/sequential/test-vm-timeout-rethrow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const spawn = require('child_process').spawn;

if (process.argv[2] === 'child') {
const code = 'let j = 0;\n' +
Copy link
Contributor

@joshgav joshgav Feb 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reduce the whole block to while(true); while you're at it? I.e. no need for declaring j either.

Copy link
Member Author

@kunalspathak kunalspathak Feb 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it intentionally so it can be used in return, but with while(true); won't be necessary. Will remove it.

'for (let i = 0; i < 1000000; i++) j += add(i, i + 1);\n' +
'while(true);\n' +
'j;';

const ctx = vm.createContext({
Copy link
Member

@addaleax addaleax Feb 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you drop theadd() function here as well?

Expand Down