Skip to content

test: add regex #11193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jobala wants to merge 8 commits into from
Closed

test: add regex #11193

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3acabec
test: add regex
Feb 1, 2017
8870c7f
test: verify error message thrown from assert.ifError
Feb 6, 2017
ac29f57
test: make regex the second argument of assert.throws
Feb 6, 2017
691ce1c
test: add space before curly brace
Feb 6, 2017
25527ff
test: fix exceed maximum lenghth lint error
Feb 7, 2017
a7a57e3
test: fix exceed maximum line length lint error
Feb 7, 2017
ccab058
test: fix indentation lint error
Feb 8, 2017
48e3497
Merge branch 'fix-test' of github.com:jobala/node into fix-test
Feb 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/parallel/test-assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ try {
assert.strictEqual(true, threw,
'a.doesNotThrow is not catching type matching errors');

assert.throws(function() { assert.ifError(new Error('test error')); });
assert.throws(function() { assert.ifError(new Error('test error')), /^Error: test error/});
Copy link
Contributor

@cjihrig cjihrig Feb 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the regular expression should come after the }. Also, please add a $ to the end of the regex.

Copy link
Author

@jobala jobala Feb 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjihrig thanks for pointing that out, I had missed the part that the regex is the optional argument to assert.throws()

assert.doesNotThrow(function() { assert.ifError(null); });
assert.doesNotThrow(function() { assert.ifError(); });

Expand Down