Skip to content

readline: update 6 comparisons to strict #11078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
umairishaq wants to merge 1 commit into from
Closed

readline: update 6 comparisons to strict #11078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/readline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ Interface.prototype._tabComplete = function(lastKeypressWasTab) {

// this = Interface instance
function handleGroup(self, group, width, maxColumns) {
if (group.length == 0) {
if (group.length === 0) {
return;
}
var minRows = Math.ceil(group.length / maxColumns);
Expand All @@ -479,15 +479,15 @@ function handleGroup(self, group, width, maxColumns) {
}

function commonPrefix(strings) {
if (!strings || strings.length == 0) {
if (!strings || strings.length === 0) {
return '';
}
if (strings.length === 1) return strings[0];
var sorted = strings.slice().sort();
var min = sorted[0];
var max = sorted[sorted.length - 1];
for (var i = 0, len = min.length; i < len; i++) {
if (min[i] != max[i]) {
if (min[i] !== max[i]) {
return min.slice(0, i);
}
}
Expand Down Expand Up @@ -702,7 +702,7 @@ Interface.prototype._ttyWrite = function(s, key) {
this._previousKey = key;

// Ignore escape key - Fixes #2876
if (key.name == 'escape') return;
if (key.name === 'escape') return;

if (key.ctrl && key.shift) {
/* Control and shift pressed */
Expand Down Expand Up @@ -783,7 +783,7 @@ Interface.prototype._ttyWrite = function(s, key) {
break;

case 'z':
if (process.platform == 'win32') break;
if (process.platform === 'win32') break;
if (this.listenerCount('SIGTSTP') > 0) {
this.emit('SIGTSTP');
} else {
Expand Down Expand Up @@ -995,7 +995,7 @@ function emitKeypressEvents(stream, iface) {
}

function onNewListener(event) {
if (event == 'keypress') {
if (event === 'keypress') {
stream.on('data', onData);
stream.removeListener('newListener', onNewListener);
}
Expand Down