Skip to content

tls: do not crash on STARTTLS when OCSP requested #10706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
indutny wants to merge 7 commits into from
Closed

tls: do not crash on STARTTLS when OCSP requested #10706

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a1b114e
tls: do not crash on STARTTLS when OCSP requested
indutny Jan 9, 2017
caa7ba1
fix
indutny Jan 9, 2017
3ef170f
fix
indutny Jan 10, 2017
7473f55
fix
indutny Jan 10, 2017
584b455
fix
indutny Jan 10, 2017
20b187b
fix
indutny Feb 3, 2017
36fd2ce
fix
indutny Feb 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/_tls_wrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ function requestOCSP(self, hello, ctx, cb) {
if (!ctx)
ctx = self.server._sharedCreds;

// Running on non-TLS server
// TLS socket is using a `net.Server` instead of a tls.TLSServer.
// Some TLS properties will not be present.
Copy link
Member

@bnoordhuis bnoordhuis Feb 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider giving one or two examples of properties that won't be there.

if (!ctx)
return cb(null);

Expand Down