process: improve performance of nextTick (v4.x backport) #10433
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces TickObject with an object literal. This offers performance improvements of up to ~20%.
nodejs-github-bot
added
c++
2 tasks
Contributor
|
Did you check that it's still a perf increase with node v4? |
Contributor
Author
|
That was a few months ago though, so double checking now |
Contributor
Author
|
Actually, next-tick-breadth.js is pretty consistently 8-10% slower on v4.x. I'll go ahead and close |
This was referenced Apr 24, 2023
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces TickObject with an object literal. This offers
performance improvements of up to ~20%.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
process
Description of change
Backport of #8932
This replaces TickObject with an object literal. This offers
performance improvements of up to ~20%.