Build of Node.js fails on 32-bit architecture (Debian)

[ms270169]

Version

v18.9.1

Platform

Linux debian11-386 5.10.0-18-686-pae #1 SMP Debian 5.10.140-1 (2022-09-02) i686 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

Installing node v18 via nvm fails:

$ nvm install 18

How often does it reproduce? Is there a required condition?

Everytime.

What is the expected behavior?

Build succeeds (as it does on version 16).

What do you see instead?

...
cc -o /home/xyz/.nvm/.cache/src/node-v18.9.1/files/out/Release/obj.target/openssl/deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.o op	86.S '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DNODE_OPENSSL_HAS_QUIC' '-D__STDC_FORMAT_MACROS' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DOPENSSL_NO_HW' '-DOPENSSL_API_COMPAT=0x10100001L' '-DSTATIC_LEGACY' '-DNDEBUG' '-DOPENSSL_USE_NODELETE' '-DL_ENDIAN' '-DOPENSSL_BUILDING_OPENSSL' '-DAES_ASM' '-DCMLL_ASM' '-DDES_ASM' '-DECP_NISTZ256_ASM' '-DGHASH_ASM' '-DMD5_ASM' '-DOPENSSL_BN_ASM_GF2m' '-DOPENSSL_BN_ASM_MONT' '-DOPENSSL_BN_ASM_PART_WORDS' '-DOPENSSL_CPUID_OBJ' '-DOPENSSL_IA32_SSE2' '-DPADLOCK_ASM' '-DPOLY1305_ASM' '-DRMD160_ASM' '-DSHA1_ASM' '-DSHA256_ASM' '-DSHA512_ASM' '-DVPAES_ASM' '-DWHIRLPOOL_ASM' '-DOPENSSL_PIC' '-DMODULESDIR="/home/xyz/.nvm/.cache/src/node-v18.9.1/files/out/Release/obj.target/deps/openssl/lib/openssl-modules"' '-DOPENSSLDIR="/etc/ssl"' '-DENGINESDIR="/dev/null"' '-DTERMIOS' -I../deps/openssl/openssl -I../deps/openssl/openssl/include -I../deps/openssl/openssl/crypto -I../deps/openssl/openssl/crypto/include -I../deps/openssl/openssl/crypto/modes -I../deps/openssl/openssl/crypto/ec/curve448 -I../deps/openssl/openssl/crypto/ec/curve448/arch_32 -I../deps/openssl/openssl/providers/common/include -I../deps/openssl/openssl/providers/implementations/include -I../deps/openssl/config -I../deps/openssl/config/archs/linux-elf/asm -I../deps/openssl/config/archs/linux-elf/asm/include -I../deps/openssl/config/archs/linux-elf/asm/crypto -I../deps/openssl/config/archs/linux-elf/asm/crypto/include/internal -I../deps/openssl/config/archs/linux-elf/asm/providers/common/include  -pthread -Wall -Wextra -Wno-unused-parameter -m32 -Wa,--noexecstack -Wall -O3 -fomit-frame-pointer -pthread -Wall -O3 -fomit-frame-pointer -Wno-missing-field-initializers -Wno-old-style-declaration -O3 -fno-omit-frame-pointer  -MMD -MF /home/xyz/.nvm/.cache/src/node-v18.9.1/files/out/Release/.deps//home/xyz/.nvm/.cache/src/node-v18.9.1/files/out/Release/obj.target/openssl/deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.o.d.raw   -c
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S: Assembler messages:
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:5: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:8: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:277: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:280: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:439: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:442: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:998: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:1001: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:1066: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:1069: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:1426: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:1429: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:1647: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:1650: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:2210: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:2213: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:2280: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:2283: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:2816: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:2819: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:3053: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:3056: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:3066: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:3069: Error: junk at end of line, first unrecognized character is `%'
make[1]: *** [deps/openssl/openssl.target.mk:1157: /home/xyz/.nvm/.cache/src/node-v18.9.1/files/out/Release/obj.target/openssl/deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.o] Fehler 1
make: *** [Makefile:113: node] Fehler 2
nvm: install v18.9.1 failed!

File aes-586.S:5:

        %ifdef __CET__

.byte   243,15,30,251
        %endif

Additional information

See also issue nvm-sh/nvm#2899

[tniessen]

Support for 32-bit Linux is experimental and we might not be testing on this platform. This looks like it might be an issue in the OpenSSL sources. cc @nodejs/build

[sxa]

Looks like it hasn't been building in the unofficial-builds since 18.4.0.
Build log log from v18.5.0 on the platform is consistent with what you're seeing.

[bnoordhuis]

Probably a toolchain issue. It's tripping on the nasm-style %ifdef statements whereas your system (and official-builds) is probably using gas (GNU as) that expects .ifdef or #ifdef (since the .S suffix means it goes through the C preprocessor.)

You can probably work around it by applying the patch below and running make -C deps/openssl/config.

diff --git a/deps/openssl/openssl/crypto/perlasm/x86asm.pl b/deps/openssl/openssl/crypto/perlasm/x86asm.pl
index 98a7159a5f1..8dcde9eacaa 100644
--- a/deps/openssl/openssl/crypto/perlasm/x86asm.pl
+++ b/deps/openssl/openssl/crypto/perlasm/x86asm.pl
@@ -174,9 +174,9 @@ sub ::vprotd
 
 sub ::endbranch
 {
-    &::generic("%ifdef __CET__\n");
+    &::generic("#ifdef __CET__\n");
     &::data_byte(0xf3,0x0f,0x1e,0xfb);
-    &::generic("%endif\n");
+    &::generic("#endif\n");
 }
 
 # label management

[ms270169]

Indeed, the problem is caused by the %ifdef and %endif statements, as @bnoordhuis mentioned.

The following statements (replacing %ifdef with #ifdef and %endif with #endif) solves the problem, and worked on all systems I tested (Debian 11 i386, Debian 11 amd64, Ubuntu 22.04 amd64):

$ wget https://nodejs.org/dist/v18.10.0/node-v18.10.0.tar.xz
$ tar -xf node-v18.10.0.tar.xz
$ cd node-v18.10.0
$ ./configure
$ for f in $(find deps/openssl -type f -name '*.S'); do echo $f; sed -i "s/%ifdef/#ifdef/" "$f"; sed -i "s/%endif/#endif/" "$f"; done
$ make
$ ./out/Release/node --version

However, I do not understand the actual cause of the problem. Without the sed substitution, the build fails on Debian i386 and Debian amd64 systems, while it works on Ubuntu 22.04 amd64 system. So it does not depend on the architecture, it depends on the system. One difference is the gcc/g++ version. Ubuntu uses gcc-11/g++-11 while Debian uses gcc-10/g++-10. But build works also on Ubuntu 22.04 when replacing gcc-11/g++-11 with gcc-10/g++-10. So it seems, that it is a toolchain problem, but not depending on compiler version. But what is the cause?

[bnoordhuis]

as is part of binutils, not gcc, but I don't think newer versions support nasm-style directives so that's probably not it. My best guess it that your ubuntu system has nasm installed.

[bnoordhuis]

I'm going to close this because the ia32 builds aren't officially supported and neither is it clear what, if anything, node could do differently. Please send a pull request if you find a fix.

[yk0055544]

How do you get nvm to install 20.5.1 on Raspbian OS x86?

[ms270169]

Building Node.js v20.12.2 on a very old 32-Bit Notebook (Intel Pentium M 750 / 1.86 GHz / Single core with Debian 12.5) also works, when additionally to comment above the Compiler option -march=native is used.

I install Node.js via Node Version Manager NVM, making small modification in the file nvm.sh in function nvm_install_source() (nvm version 0.39.1):

--- /home/user/.nvm/nvm.sh.original	2024-04-21 05:19:20.253999927 +0200
+++ /home/user/.nvm/nvm.sh	2024-04-21 10:39:00.397632022 +0200

@@ -2390,27 +2390,14 @@
   TARBALL="$(PROGRESS_BAR="${PROGRESS_BAR}" nvm_download_artifact "${FLAVOR}" source "${TYPE}" "${VERSION}" | command tail -1)" && \
   [ -f "${TARBALL}" ] && \
   TMPDIR="$(dirname "${TARBALL}")/files" && \
+
   if ! (
     # shellcheck disable=SC2086
     command mkdir -p "${TMPDIR}" && \
     command "${tar}" -x${tar_compression_flag}f "${TARBALL}" -C "${TMPDIR}" --strip-components 1 && \
     VERSION_PATH="$(nvm_version_path "${PREFIXED_VERSION}")" && \
     nvm_cd "${TMPDIR}" && \
+
+    #ms270169
+    command printf "===> ms270169 modification: ${TMPDIR}/configure.py"
+    command sed -i "s/  target_arch = 'ia32'/  target_arch = 'ia32'\n  \n  #ms270169\n  o['cflags']+=[ os.environ.get('CFLAGS', '-march=native' if target_arch == 'ia32' else '') ]\n  print(\"===> ms270169 modification: target_arch='\" + target_arch + \"', env CFLAGS='\" + os.environ.get('CFLAGS', '') + \"' -> \" + ''.join(map(str, o['cflags'])) )\n/g" configure.py
+
     nvm_echo '$>'./configure --prefix="${VERSION_PATH}" $ADDITIONAL_PARAMETERS'<' && \
     ./configure --prefix="${VERSION_PATH}" $ADDITIONAL_PARAMETERS && \
+
+    #ms270169
+    if [ "${NVM_ARCH}" = "x86" ] || [ "${NVM_ARCH}" = "ia32"  ]; then
+	command printf "===> bugfix https://github.com/nodejs/node/issues/44822\n"
+        for f in $(find deps/openssl -type f -name '*.S'); do echo $f; sed -i "s/%ifdef/#ifdef/" "$f"; sed -i "s/%endif/#endif/" "$f"; done
+    fi
+
     $make -j "${NVM_MAKE_JOBS}" ${MAKE_CXX-} && \
     command rm -f "${VERSION_PATH}" 2>/dev/null && \
     $make -j "${NVM_MAKE_JOBS}" ${MAKE_CXX-} install

With this modification compiler flag -march=native is added in file configure.py and %ifdef is replaced with #ifdef in files of deps/openssl. You can use nvm install 20 to download, build and install Node.js.