Linter failure details not shown on Travis?

[richardlau]

Has anyone seen the Travis linter job fail? Did it report the actual failure?

Looking at nodejs/build#720 it doesn't look like that tap file is echoed in the Travis config so even if the job fails the failure details are not reported:

node/.travis.yml

Lines 1 to 24 in fa2d0a1

	language: cpp
	compiler:
	- clang
	sudo: false
	cache: ccache
	matrix:
	include:
	- os: linux
	node_js: "latest"
	script:
	- NODE=$(which node) make lint-ci
	- os: linux
	install:
	- ./configure
	- make -j2 V=
	script:
	- make -j2 test-ci
	before_install:
	- export HOMEBREW_NO_AUTO_UPDATE=1 # work around https://github.com/travis-ci/travis-ci/issues/7456
	- if [ $TRAVIS_OS_NAME = osx ]; then brew install ccache; fi
	- export PATH="/usr/local/opt/ccache/libexec:$PATH"
	- export CXX="ccache clang++ -Qunused-arguments"
	- export CC="ccache clang -Qunused-arguments"
	- export JOBS=2

[richardlau]

Here's an example failing Travis linter run, https://travis-ci.com/nodejs/node/jobs/128902170:

$ NODE=$(which node) make lint-ci
Running JS linter...
make: *** [lint-js-ci] Error 1


The command "NODE=$(which node) make lint-ci" exited with 2.

So as suspected the details of the failure aren't shown making this less helpful.

[Trott]

Any idea if changing it to make lint would cause it to show the output? I wonder if the problem is stuff being swallowed by the tools/lint.js script.

[lundibundi]

@Trott not sure but maybe it's due to redirecting linter output to a file for ci target?

run-lint-js-ci = tools/lint-js.js $(PARALLEL_ARGS) -f tap -o test-eslint.tap \
		$(LINT_JS_TARGETS)

And Travis doesn't seem to be configured to read that file if the job fails like Jenkins does (latest build action).

[richardlau]

Fixed by #22417.