fix: Revert make-fetch-happen on v9 #2917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 02480f6.
lukekarrys
force-pushed
the
lk/revert-make-fetch-happen
branch
2 times, most recently
from
73db964 to
ff71ed8
Compare
Contributor
|
Upgrading to |
Fixes the failing `ruff` linting in GitHub Actions.
Member
Author
|
@cclauss This is to create a new v9 release ( The target of this PR is |
lukekarrys
changed the title
Closed
Contributor
|
The Python lint failure is fixed on node-gyp/gyp/pylib/gyp/generator/make.py Line 1995 in 91fd8ff |
Member
Author
|
Cherry picked 1bfb083 into this branch as well to fix the linting error. |
This was referenced Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 02480f6.
Closes #2849
Closes #2873
Closes #2848
Closes #2850