-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
ci: switch to GitHub Actions #2210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
4c3d33d
3cedd7e
f5d4b48
1f31e54
6d4b4ba
bf9918f
112cff0
80aa6c4
cc9942e
354c569
a1ef994
a79cac6
c41be65
ed2e0fd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,66 @@ | ||||||
| # TODO: Line 20, enable python-version: 3.5 | ||||||
| # TODO: Line 69, enable pytest --doctest-modules | ||||||
|
||||||
|
|
||||||
| name: Tests | ||||||
cclauss marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
|
|
||||||
| on: | ||||||
| push: | ||||||
| branches: | ||||||
| - master | ||||||
| pull_request: | ||||||
| branches: | ||||||
| - master | ||||||
|
||||||
| branches: | |
| - master |
I usually run tests on all pull requests on all branches. Is there a reason to avoid doing that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do just one test run on 3.9.0-rc.1 on your own to make sure that we are ready for the Py39 release in one month.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested it in cc9942e and it passes (only the doctest-modules fails so I reverted it back to a TODO)
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - name: Lint python | |
| - name: Lint Python |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - name: Run python tests (Linux and macOS) | |
| - name: Run Python tests (Linux and macOS) |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - name: Run node tests (Windows) | |
| - name: Run Node tests (Windows) |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - name: Run python tests (Windows) | |
| - name: Run Python tests (Windows) |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that Py35 reaches end-of-life in less than two weeks, let's just remove support.
https://devguide.python.org/#status-of-python-branches