Add Node.js version restrictions #1340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assumed from last Changelog the current version supports Node.js 16, 18, 20 and we should also not block 21+ for now, Right?
KevinEady
approved these changes
Jun 30, 2023
legendecas
approved these changes
Jul 3, 2023
|
Thank you! |
|
Why was this added in a minor release? This is a breaking change and should have been released in a major version |
legendecas
added a commit
to legendecas/node-addon-api
that referenced
this pull request
Jul 8, 2024
This reverts commit afa494e.
legendecas
added a commit
that referenced
this pull request
Jul 12, 2024
This reverts commit afa494e.
Released a patch version v7.1.1 to remove the engine requirement. We will still put the constraint on v8.x since we don't test older Node.js versions. Disable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assumed from last Changelog the current version supports Node.js 16, 18, 20 and we should also not block 21+ for now, Right?
fixes #1339