build: support apple silicon (arm64 darwin) builds #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzokuken
approved these changes
Jul 10, 2020
Contributor
ryzokuken
left a comment
ryzokuken
left a comment
There was a problem hiding this comment.
LGTM overall. Is there absolutely any way to be able to test this though?
Contributor
|
We will have to monitor https://blog.macstadium.com/category/macstadium-news to see when the new Apple hardware is added. |
Member
Author
|
You can test the "build" part using any machine with the Xcode 12.0 UA preview on it, but you won't be able to ensure it actually runs / works without an apple-silicon machine somewhere. Definitely works on my DTK though 😄 |
Contributor
|
@MarshallOfSound great. I'll merge this in after another review and once that's done I suppose we could make a minor release with this. Would you mind adding this to the changelog file? |
Member
Author
|
@ryzokuken Updated |
ryzokuken
approved these changes
Jul 10, 2020
Contributor
ryzokuken
left a comment
ryzokuken
left a comment
There was a problem hiding this comment.
Thanks @MarshallOfSound.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pairs with nodejs/node-gyp#2165