chore: onboard onto Python 3.12-dev and Node 18 #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
changed the title
Contributor
Author
|
I notice the (windows-latest, 3.8) integration tests contain failed tests, but the error message says Other than that, CI looks a lot more green than before. |
Contributor
|
If you have a later version of Python installed then node-gyp may try to use it. |
Contributor
Author
cclauss
approved these changes
Aug 26, 2023
rzhao271
changed the title
cclauss
added a commit
to nodejs/node-gyp
that referenced
this pull request
Sep 14, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines #196 and nodejs/node-gyp#2888