Skip to content

Conversation

@avivkeller
Copy link
Member

This PR changes the tool from using npm scripts to use npx scripts. This means that the following commands can be used, instead of npm run [...]:

npx . tsc
npx https://github.com/nodejs/create-node-meeting-artifacts tsc
npx github:nodejs/create-node-meeting-artifacts tsc
npx nodejs/create-node-meeting-artifacts tsc

Copilot AI review requested due to automatic review settings October 20, 2025 22:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR transitions the tool from using npm scripts to npx-based execution, enabling users to run the tool directly via npx commands without requiring predefined npm scripts. The binary name is also updated from create-meeting to create-node-meeting-artifacts for consistency.

  • Renamed the binary entry point to match the package name
  • Removed all meeting-specific npm scripts (45+ script entries)
  • Updated documentation to reflect npx usage patterns
  • Refactored GitHub Actions workflow to dynamically discover meeting groups

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

File Description
package.json Updated binary name and removed meeting-specific scripts and test coverage script
README.md Removed meeting commands table and updated local development examples to use npx
.github/workflows/create-meeting-artifacts-scheduled.yml Replaced hardcoded meeting matrix with dynamic discovery from template files
.github/workflows/create-meeting-artifacts-manual.yml Changed meeting_group from choice to string input and added workflow_call trigger

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

@avivkeller
Copy link
Member Author

Let's land this :-)

@ovflowd
Copy link
Member

ovflowd commented Oct 23, 2025

Do I get a cookie if I land this?

@ovflowd ovflowd merged commit fddc998 into nodejs:main Oct 23, 2025
2 checks passed
@avivkeller
Copy link
Member Author

🍪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants