ansible: install clang38 on FreeBSD 10.x machines

[kfarnung]

FreeBSD 10.x ships by default with clang-3.4.1, which is below the minimum for Node.js builds. That version (as well as 3.4.2 and 3.5.2) crashes when attempting to build V8 6.0. Specifically install the clang38 package on those hosts.

Validation steps

• Installed FreeBSD 10 and 11 on VMs
• Added them to the local Ansible inventory
• Added fake secret entries for each machine
• Ran the jenkins/worker/create playbook against both hosts
• Verified that clang38 is only installed on the FreeBSD 10 host
• Verified that the custom CC/CXX variables are only applied to the FreeBSD 10 host

[kfarnung]

/cc @nodejs/build

I used #650 as a template, but it seems like there was some refactoring done since. Are the playbooks under setup/ still used?

[kfarnung]

Looks like the CC/CXX variables are set in the init.d template: https://github.com/nodejs/build/blob/master/ansible/roles/jenkins-worker/templates/freebsd.initd.j2#L31

[gibfahn]

Are the playbooks under setup/ still used?

We're moving away from them as quickly as possible.

[kfarnung]

@gibfahn Do you want me to attempt to update the older scripts?

@jbergstroem I took a stab at adding a config for the compilers and pushed an update. I verified on my machine that it applies correctly on both FreeBSD 10 and 11 (doesn't change the latter).

As discussed in #723, it looks like clang34 (3.4.2) and clang35 (3.5.2) both crash when compiling V8 6.0. Building with clang38 (3.8.1) was successful. Are we opposed to using clang38 for FreeBSD 10 builds?

[gibfahn]

@gibfahn Do you want me to attempt to update the older scripts?

I think we should be okay just using the newer scripts, if you've tested building/testing node after using them then that's good enough for me (idk what @jbergstroem thinks though).

[mhdawson]

I think we need to document somewhere which one should be used for which platforms. For example the Raspberry Pi ones are not complete and I burned some time using the new one before realizing that. Given that we can doc that somewhere prominently I'd agree that just have the latest be updated makes sense.

[kfarnung]

It sounds like this may no longer be relevant, feel free to close if that's the case.

[kfarnung]

Closing this out, feel free to resurrect if necessary.