Skip to content

[CI] Fix CI failures #2679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[CI] Fix CI failures #2679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cec9e1
[CI] Fix CI failures
vivekkhandelwal1 Nov 19, 2025
dbcd7d3
Merge branch 'main' into fix-ci
vivekkhandelwal1 Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci-amdsharktank.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ jobs:
name: Coverage
runs-on: ubuntu-24.04
needs: test
if: github.event.pull_request.number != 2677 # Skip for large PR that exceeds GitHub's 300-file diff limit
permissions:
pull-requests: write
contents: write
Expand Down Expand Up @@ -289,7 +288,7 @@ jobs:

# Depends on other jobs to provide an aggregate job status.
# TODO(#584): move test_with_data and test_integration to a pkgci integration test workflow?
ci_amdsharktank_summary: # TODO: rename to ci_amdsharktank_summary
ci_amdsharktank_summary:
if: always()
runs-on: ubuntu-24.04
needs:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ci-amdsharktuner.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ jobs:
name: Coverage
runs-on: ubuntu-24.04
needs: test
if: github.event.pull_request.number != 2677 # Skip for large PR that exceeds GitHub's 300-file diff limit
permissions:
pull-requests: write
contents: write
Expand Down
4 changes: 2 additions & 2 deletions shortfin/tests/host_cpu_system_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ def test_create_host_cpu_system_defaults():
assert len(ls.devices) > 0


@pytest.mark.skip(
reason="IREE UNIMPLEMENTED: threadless donate-only executor mode not yet implemented with hostcpu_topology_max_group_count=2"
@pytest.mark.skipif(
sys.platform == "win32", reason="Windows fatal exception: access violation"
)
def test_create_host_cpu_system_topology_nodes_all():
sc = sf.host.CPUSystemBuilder(
Expand Down
Loading