HOST_TX_READY_NOTIFY attr changed to set after query capabilities#12
Closed
HOST_TX_READY_NOTIFY attr changed to set after query capabilities#12
Conversation
noaOrMlnx
force-pushed
the
host_tx_ready_notify_callback_change
branch
from
03c85dd to
9546d2a
Compare
noaOrMlnx
force-pushed
the
host_tx_ready_notify_callback_change
branch
from
9546d2a to
47319dd
Compare
keboliu
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Changed SAI_SWITCH_ATTR_PORT_HOST_TX_READY_NOTIFY callback attribute to be set only after query capabilities approved that CMIS mgmt. feature is enabled.
Why I did it
Before that change, in orchagent/main.cpp, that attribute was set without checking if SAI version is not supporting this feature.
This could cause an issue to unsupported SAI versions with supported SONiC versions.
How I verified it
Made sure all functionality is the same as before, and this attribute set will not break not-supporting SAI versions.
Details if related