Skip to content

Prevent creation of attributes with invalid characters#448

Merged
Milena-Czierlinski merged 17 commits intorelease/v7from
character-set-validation-in-consumption
Jul 2, 2025
Merged

Prevent creation of attributes with invalid characters#448
Milena-Czierlinski merged 17 commits intorelease/v7from
character-set-validation-in-consumption

Conversation

@Magnus-Kuhn
Copy link
Copy Markdown
Contributor

@Magnus-Kuhn Magnus-Kuhn commented Mar 6, 2025

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

Description

This validates invalid characters in attributes when

  • creating or succeeding a repository attribute
  • creating or accepting a CreateAttributeRequestItem/ProposeAttributeRequestItem (in canCreate / canAccept)
  • accepting a ReadAttributeRequestItem

Those validations occur mostly on the sender's side (except the canAccept CreateAttributeRequestItem).

Possibilities to expand this validation are

  • incoming notifications after attribute succession
  • attributeQueries
  • ShareAttributeRequestItems
  • applyResponseItem handlers

@Magnus-Kuhn Magnus-Kuhn added wip Work in Progress (blocks mergify from auto update the branch) enhancement New feature or request labels Mar 6, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 120 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkoenig134
Copy link
Copy Markdown
Contributor

Very nice, going down from 48 changed files to only 9!!

@jkoenig134 jkoenig134 removed the wip Work in Progress (blocks mergify from auto update the branch) label Jul 1, 2025
@Milena-Czierlinski Milena-Czierlinski changed the base branch from main to release/v7 July 1, 2025 14:15
@Milena-Czierlinski Milena-Czierlinski marked this pull request as ready for review July 1, 2025 16:22
@jkoenig134 jkoenig134 added the breaking-change A breaking change label Jul 2, 2025
@Milena-Czierlinski Milena-Czierlinski merged commit b38405c into release/v7 Jul 2, 2025
16 checks passed
@Milena-Czierlinski Milena-Czierlinski deleted the character-set-validation-in-consumption branch July 2, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change A breaking change enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants