Add validation for tags of Attributes#436
Merged
britsta merged 46 commits intorelease/v7from Mar 6, 2025
Merged
Conversation
Member
Milena-Czierlinski
left a comment
There was a problem hiding this comment.
I haven't checked the non-trivial tests, yet, since they might change.
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
...n/src/modules/requests/itemProcessors/createAttribute/CreateAttributeRequestItemProcessor.ts
Outdated
Show resolved
Hide resolved
Magnus-Kuhn
reviewed
Feb 25, 2025
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
packages/consumption/test/modules/attributes/AttributesController.test.ts
Outdated
Show resolved
Hide resolved
...odules/requests/itemProcessors/proposeAttribute/ProposeAttributeRequestItemProcessor.test.ts
Outdated
Show resolved
Hide resolved
...st/modules/requests/itemProcessors/shareAttribute/ShareAttributeRequestItemProcessor.test.ts
Outdated
Show resolved
Hide resolved
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
britsta
reviewed
Feb 25, 2025
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
packages/consumption/test/modules/attributes/AttributesController.test.ts
Show resolved
Hide resolved
packages/consumption/test/modules/attributes/AttributesController.test.ts
Show resolved
Hide resolved
packages/consumption/test/modules/attributes/AttributesController.test.ts
Outdated
Show resolved
Hide resolved
packages/consumption/test/modules/attributes/AttributesController.test.ts
Outdated
Show resolved
Hide resolved
.../modules/requests/itemProcessors/createAttribute/CreateAttributeRequestItemProcessor.test.ts
Show resolved
Hide resolved
...st/modules/requests/itemProcessors/shareAttribute/ShareAttributeRequestItemProcessor.test.ts
Outdated
Show resolved
Hide resolved
...st/modules/requests/itemProcessors/shareAttribute/ShareAttributeRequestItemProcessor.test.ts
Outdated
Show resolved
Hide resolved
Magnus-Kuhn
reviewed
Feb 27, 2025
...odules/requests/itemProcessors/proposeAttribute/ProposeAttributeRequestItemProcessor.test.ts
Show resolved
Hide resolved
...test/modules/requests/itemProcessors/readAttribute/ReadAttributeRequestItemProcessor.test.ts
Show resolved
Hide resolved
...st/modules/requests/itemProcessors/shareAttribute/ShareAttributeRequestItemProcessor.test.ts
Show resolved
Hide resolved
packages/consumption/test/modules/attributes/AttributesController.test.ts
Outdated
Show resolved
Hide resolved
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
… into feature/add_tag_validation
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
...n/src/modules/requests/itemProcessors/createAttribute/CreateAttributeRequestItemProcessor.ts
Outdated
Show resolved
Hide resolved
...n/src/modules/requests/itemProcessors/createAttribute/CreateAttributeRequestItemProcessor.ts
Show resolved
Hide resolved
Milena-Czierlinski
approved these changes
Mar 6, 2025
jkoenig134
approved these changes
Mar 6, 2025
This was referenced May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness checklist