Skip to content

Add validation for tags of Attributes#436

Merged
britsta merged 46 commits intorelease/v7from
feature/add_tag_validation
Mar 6, 2025
Merged

Add validation for tags of Attributes#436
britsta merged 46 commits intorelease/v7from
feature/add_tag_validation

Conversation

@sebbi08
Copy link
Copy Markdown
Contributor

@sebbi08 sebbi08 commented Feb 25, 2025

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 84.33735% with 26 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...teAttribute/CreateAttributeRequestItemProcessor.ts 44.44% 20 Missing ⚠️
...ion/src/modules/attributes/AttributesController.ts 92.40% 6 Missing ⚠️
Files with missing lines Coverage Δ
...nsumption/src/consumption/ConsumptionCoreErrors.ts 81.44% <100.00%> (+0.19%) ⬆️
...eAttribute/ProposeAttributeRequestItemProcessor.ts 92.47% <100.00%> (+0.31%) ⬆️
...readAttribute/ReadAttributeRequestItemProcessor.ts 92.60% <100.00%> (+0.15%) ⬆️
...areAttribute/ShareAttributeRequestItemProcessor.ts 93.83% <100.00%> (+0.40%) ⬆️
...ion/src/modules/attributes/AttributesController.ts 93.34% <92.40%> (-0.07%) ⬇️
...teAttribute/CreateAttributeRequestItemProcessor.ts 80.63% <44.44%> (-1.27%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sebbi08 sebbi08 changed the title Feature/add tag validation Add tag validation for attributes Feb 25, 2025
@sebbi08 sebbi08 added the enhancement New feature or request label Feb 25, 2025
@sebbi08 sebbi08 marked this pull request as ready for review February 25, 2025 11:31
Copy link
Copy Markdown
Member

@Milena-Czierlinski Milena-Czierlinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked the non-trivial tests, yet, since they might change.

@britsta britsta merged commit fb4d660 into release/v7 Mar 6, 2025
15 checks passed
@britsta britsta deleted the feature/add_tag_validation branch March 6, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change A breaking change enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants