Skip to content

Prevent creation of RepositoryAttribute duplicates by accepting a ReadAttributeRequestItem#423

Merged
Milena-Czierlinski merged 14 commits intomainfrom
prevent-duplicates-by-readattributerequestitem
Feb 19, 2025
Merged

Prevent creation of RepositoryAttribute duplicates by accepting a ReadAttributeRequestItem#423
Milena-Czierlinski merged 14 commits intomainfrom
prevent-duplicates-by-readattributerequestitem

Conversation

@Milena-Czierlinski
Copy link
Copy Markdown
Member

@Milena-Czierlinski Milena-Czierlinski commented Feb 18, 2025

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@Milena-Czierlinski Milena-Czierlinski added the enhancement New feature or request label Feb 18, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 84.48276% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ribute/AcceptReadAttributeRequestItemParameters.ts 40.00% 8 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
...readAttribute/ReadAttributeRequestItemProcessor.ts 92.43% <100.00%> (+0.69%) ⬆️
...ribute/AcceptReadAttributeRequestItemParameters.ts 65.47% <40.00%> (-5.54%) ⬇️

@Milena-Czierlinski Milena-Czierlinski marked this pull request as ready for review February 19, 2025 08:30
Copy link
Copy Markdown
Contributor

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Milena-Czierlinski Milena-Czierlinski merged commit 7dadb23 into main Feb 19, 2025
15 checks passed
@Milena-Czierlinski Milena-Czierlinski deleted the prevent-duplicates-by-readattributerequestitem branch February 19, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants