fix(login): added hashing for passwords #1199
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storing passwords in plaintext is a security risk, the proper way to store passwords is to store only the hash value of the password. Hash functions such as SHA are general purpose, other solutions like pbkdf2 offer more security by making the hash procedure much more computationally intensive, preventing some attacks.
|
How has there been a fix for more than 3 years, but the passwords are still stored in plain text? Boggles my mind. How people implement plain text passwords in the first place is insane. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing passwords in plaintext is a security risk,
the proper way to store passwords is to store
only the hash value of the password.
Hash functions such as SHA are general purpose,
other solutions like pbkdf2 offer more security by
making the hash procedure much more computationally
intensive, preventing some attacks.