docs: remove unnecessary template before get in README & docs (fixes #4825) #4920
+64
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you take a look at the PR will turn the DCO green once all checks are passed! |
|
Please rebase to the latest develop branch so the CI can run successfully. Also please check https://github.com/nlohmann/json/pull/4920/checks?check_run_id=50274941755 |
This was
linked to
issues
Sep 16, 2025
|
Hi @aryanrahar, can you please rebase? |
|
Actually my midsem exams are going i will do the work in 1-2 days!
…On Sat, 20 Sep 2025 at 8:09 PM, Niels Lohmann ***@***.***> wrote:
*nlohmann* left a comment (nlohmann/json#4920)
<#4920 (comment)>
Hi @aryanrahar <https://github.com/aryanrahar>, can you please rebase?
—
Reply to this email directly, view it on GitHub
<#4920 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BU52OI37IHVKF43B7B7HJGT3TVRIRAVCNFSM6AAAAACGMH6RHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMJVGAYDQOJTHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No worries - good luck to you! 🍀 |
5 tasks
aryanrahar
force-pushed
the
docs/fix-4825-remove-template-get
branch
2 times, most recently
from
b626754 to
3ab4582
Compare
|
Can you approve the change? |
|
is there any issue? |
|
Can you please rebase to the latest |
…ADME & MkDocs (fixes nlohmann#4825) Signed-off-by: aryanrahar <[email protected]>
aryanrahar
force-pushed
the
docs/fix-4825-remove-template-get
branch
from
3ab4582 to
41a0fee
Compare
|
Done
done |
|
I just merged #4846 which worked on the same issue. Please rebase your branch to see whether there is anything left to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request resolves issue #4825 by removing the unnecessary template keyword from get() calls in non-dependent contexts throughout the README and MkDocs documentation.
What
Replaced .template get<...>() with .get<...>() in documentation examples where it was not required.
No library code was changed.
Why
Improves the clarity and correctness of the code examples for users.
The .template keyword is only necessary for dependent names in C++ templates and can be confusing when used outside of that context.
How Tested
Successfully built and previewed the documentation locally using mkdocs.
Ran the full CTest suite as a courtesy check to ensure no regressions were introduced.