Skip to content

Fix C4702 warning and extend MSVC CI job #4749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 17, 2025
Merged

Fix C4702 warning and extend MSVC CI job #4749

merged 6 commits into from
Apr 17, 2025

Conversation

@nlohmann
Copy link
Owner

@nlohmann nlohmann commented Apr 17, 2025 •
edited
Loading

Closes #4745

@nlohmann
⚗️ try matrix for latest
2cd14a6 
Signed-off-by: Niels Lohmann <[email protected]>
@coveralls
Copy link

coveralls commented Apr 17, 2025 •
edited
Loading

Coverage Status

coverage: 99.188%. remained the same
when pulling 7b2d94d on issue4745
into 88c92e6 on develop.

nlohmann added 2 commits April 17, 2025 10:13
@nlohmann
♻️ refactor from #4745 (comment)
5113ed1 
Signed-off-by: Niels Lohmann <[email protected]>
@nlohmann
👷 simplify CI
2cccf39 
Signed-off-by: Niels Lohmann <[email protected]>
@github-actions github-actions bot added L and removed M labels Apr 17, 2025
nlohmann added 3 commits April 17, 2025 10:32
@nlohmann
👷 simplify CI
adea4a7 
Signed-off-by: Niels Lohmann <[email protected]>
@nlohmann
🚨 fix cpplint warning
acb68d7 
Signed-off-by: Niels Lohmann <[email protected]>
@nlohmann
👷 simplify CI
7b2d94d 
Signed-off-by: Niels Lohmann <[email protected]>
@nlohmann nlohmann changed the title Add matrix step for latest C++ standard in MSVC job Fix C4702 warning and extend MSVC CI job Apr 17, 2025
@nlohmann nlohmann added this to the Release 3.12.1 milestone Apr 17, 2025
@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Apr 17, 2025
@nlohmann nlohmann marked this pull request as ready for review April 17, 2025 09:43
@nlohmann nlohmann mentioned this pull request Apr 17, 2025
Closed
2 tasks
@simonedi
Copy link

simonedi commented Apr 17, 2025

Looks good for me. No warnings occurring anymore.

gregmarr
gregmarr reviewed Apr 17, 2025
View reviewed changes
@nlohmann nlohmann merged commit c67d538 into develop Apr 17, 2025
139 checks passed
@nlohmann nlohmann deleted the issue4745 branch April 17, 2025 16:04
@JoshuaVandaele JoshuaVandaele mentioned this pull request Sep 25, 2025
Draft
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gregmarr gregmarr gregmarr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI L review needed It would be great if someone could review the proposed changes.

Projects

None yet

Milestone

Release 3.12.1

Development

Successfully merging this pull request may close these issues.

[MSVC] [std:c++latest] Warning C4702 after updating to json 3.12.0 with Visual Studio 2022 17.12.7

5 participants

@nlohmann @coveralls @simonedi @gregmarr