-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
build2 integration doc update #4587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@nlohmann Hi! I'm not done at all with this but I would need to see the result somewhere before continuing. Does the ci makes a documentation build? I didnt find it so far. |
You can execute make install_venv serve -C docs/mkdocsand then open http://127.0.0.1:8000/ |
|
This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions! |
|
Still relevant, just no time to focus on this yet. T_T I'll try this weekend but can't make any promises. |
|
Please resolve conflicts and sign off your commits (see https://github.com/nlohmann/json/pull/4587/checks?check_run_id=35268369393). |
b3f711e to
7b12a7b
Compare
|
I took some time to update this but I'm having some issues:
I'll try to complete this soon, I didnt try to generate the doc yet by lack of time (and no |
See https://github.com/nlohmann/json/pull/4587/checks?check_run_id=40451156048. There, a solution is described:
Yes.
Please revert. |
|
I still have some cleanup to do, but no time left today, will continue soon. 👍🏽 |
114773d to
dcdcdb0
Compare
|
I created #4801 to fix the CI. Please rebase once this is merged. |
|
#4801 is merged. Please rebase. |
|
I still need to do a pass on the rendering, I didnt have an opportunity yet but should be able to work on it this week. |
c8b5f2d to
a2eb54c
Compare
|
Please rebase to the latest |
Signed-off-by: Joël Lamotte <[email protected]> Signed-off-by: Klaim (Joël Lamotte) <[email protected]>
Signed-off-by: Joël Lamotte <[email protected]> Signed-off-by: Klaim (Joël Lamotte) <[email protected]>
Signed-off-by: Joël Lamotte <[email protected]> Signed-off-by: Klaim (Joël Lamotte) <[email protected]>
Signed-off-by: Klaim (Joël Lamotte) <[email protected]>
Signed-off-by: Klaim (Joël Lamotte) <[email protected]>
Signed-off-by: Klaim (Joël Lamotte) <[email protected]>
Signed-off-by: Klaim (Joël Lamotte) <[email protected]>
Signed-off-by: Klaim (Joël Lamotte) <[email protected]>
nlohmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
LGTM. The PR is still in draft though. 🤔 |
|
Sorry about that, I kept it in draft mainly because of some formatting/rendering issues I was fixing but didnt have time to focus on recently. If the current state is good (I dont have the rendering at hand to check, I'm on another machine) then great! Otherwise I'll fix the last details this weekend. |
This PR adds a more complete description of how to use the
build2's package ofnlhomann-jsonto consume the library inbuild2projects.Note that
build2is not only a package-manager but also a build-system and both tools are designed to work together, this impacts the verbosity of this documentation. I might have been too detailed or beginner-friendly in some parts, feel free to point if I should shortcut some of the explanations. In doubt, for the case of exisingbuild2projects, I opted to use the "detail/summary" markdown/html tags so that people who already know about these steps (experimentedbuild2users) dont have to read the whole paragraph. The details are for less experimentedbuild2users.The provided source files do not constitute as provided a valide
build2project, that involves a specific organisation in particular for projects that use the package-manager. So instead of adding a whole project, I put there the files that will be modified from abdep new-created project (that command creates a ready-to-work project). The example "from scratch" uses that approach.Because
build2projects with executables usually usetestscript, the executable I/O testing tooling provided bybuild2, I also provided atestscriptfor testing the output from the classic output of the example source code.Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmanndirectory, runmake amalgamateto create the single-header filessingle_include/nlohmann/json.hppandsingle_include/nlohmann/json_fwd.hpp. The whole process is described here.Please don't
#ifdefs or other means.