Simplify and optimize inotify and fanotify read_events APIs#2741
Open
sami-daniel wants to merge 1 commit intonix-rust:masterfrom
Open
Simplify and optimize inotify and fanotify read_events APIs#2741sami-daniel wants to merge 1 commit intonix-rust:masterfrom
inotify and fanotify read_events APIs#2741sami-daniel wants to merge 1 commit intonix-rust:masterfrom
Conversation
Remove logic with `MaybeUninit` + `copy_nonoverlapping` and use `ptr::read_unaligned`, leaving the code more concise and clean on both sides, without the redundant check using `.min()` Use `Vec::with_capacity(nread / size)` instead of allocating empty space. Useful for increasing performance in case of event bursts. Allocates space to spare, but is still more performant than allocating almost empty space. Reduce the event name iteration window to the maximum byte size (which is `event.len`), without risking reading beyond the event name in any way and without needing to scan again using `CStr::from_ptr` and increasing perfomance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
In both the inotify and fanotify
read_events(...)APIs:Remove logic with
MaybeUninit+copy_nonoverlappingand useptr::read_unaligned, leaving the code more concise and clean on both sides, without the redundant check using.min()Use
Vec::with_capacity(nread / size)instead of allocating empty space. Useful for increasing performance in case of event bursts. Allocates space to spare, but is still more performant than allocating almost empty space.In inotify
read_events:Reduce the event name iteration window to the maximum byte size (which is
event.len), without risking reading beyond the event name in any way and without needing to scan again usingCStr::from_ptrand increasing perfomanceChecklist:
CONTRIBUTING.md