Skip to content

starship: add presets option#8214

Merged
khaneliman merged 1 commit into
nix-community:masterfrom
bandithedoge:starship-presets
Feb 27, 2026
Merged

starship: add presets option#8214
khaneliman merged 1 commit into
nix-community:masterfrom
bandithedoge:starship-presets

Conversation

@bandithedoge
Copy link
Copy Markdown
Contributor

Description

Fixes #7297. Mirrors NixOS/nixpkgs@68543ba.

I'm not sure how to do test cases that don't have to be manually updated along with Starship. Is it alright to use IFD in the test and compare attrsets parsed from TOML?

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.

  • Code tested through nix run .#tests -- test-all or
    nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

@github-actions github-actions Bot added the shell label Nov 25, 2025
Copy link
Copy Markdown
Collaborator

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a crucial setting so it's fine if not tested. IFD in tests would be fine I beleive. If someone can confirm it works, we can merge as is

Copy link
Copy Markdown
Contributor

@Invizory Invizory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone can confirm it works, we can merge as is

Works for me :)

@bandithedoge bandithedoge marked this pull request as ready for review January 11, 2026 16:01
@khaneliman
Copy link
Copy Markdown
Collaborator

IFD in tests would be fine I beleive.

Ideally, used nowhere..realistically, it's probably fine in tests since it won't leak IFD into a user eval and just be a contributor limitation. But, we have them guarded atm behind a flag to prevent people from being blocked on contributing due to IFD. #6905 introduced the argument to guard IFD as opt-in

@Invizory
Copy link
Copy Markdown
Contributor

Is something still blocking this PR from merging?

@bandithedoge
Copy link
Copy Markdown
Contributor Author

Not that I'm aware of.

@khaneliman khaneliman merged commit ec4e115 into nix-community:master Feb 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support programs.starship.preset to use official Starship presets

4 participants