starship: add presets option#8214
Merged
Merged
Conversation
teto
approved these changes
Nov 29, 2025
Collaborator
teto
left a comment
There was a problem hiding this comment.
it's not a crucial setting so it's fine if not tested. IFD in tests would be fine I beleive. If someone can confirm it works, we can merge as is
Invizory
approved these changes
Jan 11, 2026
Contributor
Invizory
left a comment
There was a problem hiding this comment.
If someone can confirm it works, we can merge as is
Works for me :)
649ad7a to
9a777e3
Compare
Collaborator
Ideally, used nowhere..realistically, it's probably fine in tests since it won't leak IFD into a user eval and just be a contributor limitation. But, we have them guarded atm behind a flag to prevent people from being blocked on contributing due to IFD. #6905 introduced the argument to guard IFD as opt-in |
Contributor
|
Is something still blocking this PR from merging? |
Contributor
Author
|
Not that I'm aware of. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7297. Mirrors NixOS/nixpkgs@68543ba.
I'm not sure how to do test cases that don't have to be manually updated along with Starship. Is it alright to use IFD in the test and compare attrsets parsed from TOML?
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.