Add declarative unmount #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
force-pushed
the
verity
branch
2 times, most recently
from
ebe8ae3 to
cca4d92
Compare
Mic92
force-pushed
the
verity
branch
4 times, most recently
from
57d9188 to
b4dd32e
Compare
Mic92
commented
Nov 29, 2024
Mic92
force-pushed
the
verity
branch
3 times, most recently
from
ec8c02b to
e601155
Compare
Mic92
force-pushed
the
verity
branch
2 times, most recently
from
919ccea to
aa00625
Compare
Lassulus
approved these changes
Nov 29, 2024
Collaborator
Lassulus
left a comment
Lassulus
left a comment
There was a problem hiding this comment.
changes lgtm, since this just adds new functionality and doesn't touch old one. I would be fine with testing this one "in production" :)
Collaborator
|
@mergify queue |
Contributor
🛑 The pull request has been merged manuallyThe pull request has been merged manually at a75ba3b |
Member
Author
|
I actually want to make it a dependency in nixos-anywhere and disko-install |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.