Activate unmount tests #1150
Open
Activate unmount tests #1150
+64
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix typo against full dataset path argument - Make unmount with encryption keys idempotent
…sting non-empty path
The value for device is copied into the SOURCE column of findmnt. By default this is "none". The mount and unmount scripts branch on SOURCE=fsType specifically, and the existence of "none" in the SOURCE column causes wrong branches to be executed. For a list of special filesystems, the default value "none" is replaced by the value for fsType.
Bert-Proesmans
force-pushed
the
activate_unmount_tests
branch
from
f093f6a to
20a8e8e
Compare
- Fix consistent use of fully qualified dataset path - Add idempotent unmounting with encryption keys
Bert-Proesmans
force-pushed
the
activate_unmount_tests
branch
from
20a8e8e to
0ad0b06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of stacked pull requests to enable unmount testing. This is PR 4 out of 4. Stacks on top of #1149.
Only the last commit applies to this PR.
Adds missing testscript code to execute unmount scripts. With this change all test derivations of the Disko examples verify proper unmounting behaviour.
See #1140 for ealier discussion.