-
-
Notifications
You must be signed in to change notification settings - Fork 763
refactor!: switch to tinyglobby #3257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c515fe7 to
1b1c728
Compare
|
@pi0 just checking in to see if you might be able to give this a look. thanks! |
|
It is under my track. SuperchupuDev/tinyglobby#70 has not been solved yet (without it, users cannot ignore some public paths) |
|
Thanks for the update! I see now that you'd mentioned that on the PR targeting v2, but I'm afraid I'd forgotten Regarding the negated ignore feature, is there a project you're aware of that would need the feature? Thus far it hasn't been prioritized as it seems mostly theoretical. Most nitro users are probably already using tinyglobby as it's been adopted by Vite, Nuxt, etc. and I haven't seen anyone hit this issue yet, so I wonder if we could just list this in the breaking changes since it's going into a major |
|
Users should be able to ignore specific FS scan patterns and public assets. This was a feature Nitro (and Nuxt by using Nitro) always had and certainly users are depending on it (including current Nuxt users even if other glob uses do not need negate). This is an important feature. We can polyfill this feature support (Nuxt additionally uses ignore). really shouldn't be something that hard to achieve from tinyglobby to replace a previous package usage specially when targeting lower install size. |
|
I certainly agree on the need to ignore specific patterns! That works in I'm not against adding the feature at all! Unfortunately it's blocked by an upstream PR which has gone unreviewed: micromatch/picomatch#137 |
1720448 to
16a2cef
Compare
|
@benmccann is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
16a2cef to
465f5ca
Compare
|
|
|
This is good for (removed covering feature: 4fbd74e) To backport |
|
thanks!! |
π Linked issue
#3108, but against the v3 branch
β Type of change
π Description
https://npmgraph.js.org/?q=globby - 23 dependencies
https://npmgraph.js.org/?q=tinyglobby - 2 dependencies
π Checklist