Skip to content

fix: update keyvalue perms #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix: update keyvalue perms #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions nitric/keyvalue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ import (
type KvStorePermission string

const (
KvStoreWrite KvStorePermission = "write"
KvStoreRead KvStorePermission = "read"
KvStoreSet KvStorePermission = "set"
KvStoreGet KvStorePermission = "get"
KvStoreDelete KvStorePermission = "delete"
)

var KvStoreEverything []KvStorePermission = []KvStorePermission{KvStoreWrite, KvStoreRead, KvStoreDelete}
var KvStoreEverything []KvStorePermission = []KvStorePermission{KvStoreSet, KvStoreGet, KvStoreDelete}

type KvStore interface {
Allow(KvStorePermission, ...KvStorePermission) (keyvalue.Store, error)
Expand Down Expand Up @@ -80,9 +80,9 @@ func (m *manager) newKv(name string, permissions ...KvStorePermission) (keyvalue
actions := []v1.Action{}
for _, perm := range permissions {
switch perm {
case KvStoreRead:
case KvStoreGet:
actions = append(actions, v1.Action_KeyValueStoreRead)
case KvStoreWrite:
case KvStoreSet:
actions = append(actions, v1.Action_KeyValueStoreWrite)
case KvStoreDelete:
actions = append(actions, v1.Action_KeyValueStoreDelete)
Expand Down