Fix wayland event loop overflow after only a few hundred millisecond#1699
Closed
KosmX wants to merge 1 commit intoniri-wm:mainfrom
Closed
Fix wayland event loop overflow after only a few hundred millisecond#1699KosmX wants to merge 1 commit intoniri-wm:mainfrom
KosmX wants to merge 1 commit intoniri-wm:mainfrom
Conversation
Author
|
The auto-build will definitely fail to build without the updated wayland-rs :D |
Member
|
Good idea, but please no config option for this. Why would anyone want to configure their system to be broken? Just make it work by default. Copy whatever Mutter does |
Author
Author
|
Force pushed the buffer size, this time without config. And I did a quick rebase. |
Member
|
Looks good, don't forget to run rustfmt |
Author
|
rustfmt? what is that? :D |
This is needed on higher-end systems, because if I use a high polling rate mice (1kHz), and the app stops receiving events for 200 ms, that is enough to overflow the event buffer, and crashes the app.
|
Wayland-rs is released, so this should now be able to use https://docs.rs/wayland-server/0.31.12/wayland_server/struct.DisplayHandle.html#method.set_default_max_buffer_size. |
5 tasks
Member
|
Added in b82d527 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed on higher-end systems, because if I use a high polling rate mice (1kHz), and the app stops receiving events for 200 ms, that is enough to overflow the event buffer, and crashes the app.
With this patch, the buffer can be increased, and these apps can have more time handling inputs
the default buffer size is 4096 bytes, which is pretty small.
The buffer can be set with the global
max-buffer-sizeconfig.If the config is not specified, the value won't be overwritten.
I'll set ready-to-merge on this PR when Smithay/wayland-rs#815 is merged and released.