Skip to content

added asl-support content in utils.py and dicoms.py files #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

added asl-support content in utils.py and dicoms.py files #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions heudiconv/dicoms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,11 @@ def create_seqinfo(mw: dw.Wrapper, series_files: list[str], series_id: str) -> S
date=dcminfo.get("AcquisitionDate"),
series_uid=dcminfo.get("SeriesInstanceUID"),
time=dcminfo.get("AcquisitionTime"),
# ASL support
in_plane_phase_encoding_direction = dcminfo.get("InPlanePhaseEncodingDirection") if dcminfo.get("InPlanePhaseEncodingDirection") else None,
Copy link
Member

@yarikoptic yarikoptic Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just

Suggested change
in_plane_phase_encoding_direction = dcminfo.get("InPlanePhaseEncodingDirection") if dcminfo.get("InPlanePhaseEncodingDirection") else None,
in_plane_phase_encoding_direction = dcminfo.get("InPlanePhaseEncodingDirection"),

and so on would be sufficient. But first please elaborate why these particular are necessary for ASL support?
Note: we do not really want to extend list of extracted fields to get unnecessarily long.

NB I should really look into finishing #581 some days soon to provide means for easy extraction of any metadata desired.

acquisition_number = dcminfo.get("AcquisitionNumber") if dcminfo.get("AcquisitionNumber") else None,
image_orientation_patient = tuple(dcminfo.get('ImageOrientationPatient')) if dcminfo.get('ImageOrientationPatient') else ()

)


Expand Down
4 changes: 4 additions & 0 deletions heudiconv/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ class SeqInfo(NamedTuple):
date: Optional[str] # 24
series_uid: Optional[str] # 25
time: Optional[str] # 26
# additional ASL supported files
image_orientation_patient: Optional[tuple]
in_plane_phase_encoding_direction: Optional[str]
acquisition_number: Optional[str]


class StudySessionInfo(NamedTuple):
Expand Down