This repository was archived by the owner on Nov 25, 2024. It is now read-only.
chore: configured SvelteKit for Netlify#46
Merged
nickytonline merged 3 commits intonickytonline:mainfrom Oct 14, 2022
Merged
Conversation
sadiejay
reviewed
Oct 14, 2022
Collaborator
sadiejay
left a comment
sadiejay
left a comment
There was a problem hiding this comment.
I think this looks good to me! @nickytonline @Narigo
Owner
|
@sadiejay, it's all good based on my inital instructions in the issue, but I realized when testing this tonight, I clearly missed something. I dropped the updated instructions here, #45 (comment) |
nickytonline
approved these changes
Oct 14, 2022
Owner
nickytonline
left a comment
nickytonline
left a comment
There was a problem hiding this comment.
Looks great @gentlegiantdev! Thanks so much for the pull request! 🚀
nickytonline
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Removed "netlify.toml".
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
UI accessibility concerns?
If your PR includes UI changes, please replace this line with details on how
accessibility is impacted and tested. For more info, check out the awesome
Forem Accessibility Docs.
Added/updated tests?
have not been included
[optional] What gif best describes this PR or how it makes you feel?