Skip to content

Avoid duplicating warning in ng-repeat#91

Open
rhcad wants to merge 1 commit intonickperkinslondon:masterfrom
rhcad:master
Open

Avoid duplicating warning in ng-repeat#91
rhcad wants to merge 1 commit intonickperkinslondon:masterfrom
rhcad:master

Conversation

@rhcad
Copy link

@rhcad rhcad commented Dec 1, 2015

  1. Add " '~' + $index" in the following line:

    <li ng-repeat = "row in tree_rows | filter...track by row.branch.uid || '~' + $index">

    When row.branch.uid is empty, ng-repeat error will occur: "Duplicates in a repeater are not allowed".

  2. Fix the variables of the example in README.

    <abn-tree tree-data = "my_treedata" ...>

    $scope.my_treedata = [{ // Replace 'my_data' with 'my_treedata'
      label: 'Languages',
      children: ['Jade','Less','Coffeescript']
    }]
  3. Add repository and fix license in package.son (licence -> license).

1. Add "'~' + $index" in the following line:
<li ng-repeat = "row in tree_rows | filter...track by row.branch.uid || '~' + $index">

When row.branch.uid is empty, ng-repeat error will occur: "Duplicates in a repeater are not allowed".

2. Fix the variables of the example in README.

3. Add repository and fix license in package.json.
@daerogami
Copy link
Collaborator

uid should never be empty so I'm not sure if this change is necessary; however, the other cleanup items are still valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants