Optional tag filter #205
Merged
Optional tag filter #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 69.26% 69.49% +0.22%
==========================================
Files 45 45
Lines 5030 5041 +11
==========================================
+ Hits 3484 3503 +19
+ Misses 1424 1416 -8
Partials 122 122
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Owner
|
Reviewing now. |
Author
|
Oddly enough, if I run |
- Refactor `FilterByImage` to support optional tag matching with helper function `matchImageAndTag` - Add tests for malformed image inputs in `filters_test.go` - Update `http-api-mode.md` to document tag support in /v1/update endpoint - Add reference in `arguments.md` for tag filtering discoverability
Owner
|
I'm using Golangci-lint to provide more thorough linting requirements, which is why go fmt might have missed it. |
nicholas-fedor
previously approved these changes
Apr 14, 2025
- Add test for insecure HTTP URL warning in gotify notifier initialization
nicholas-fedor
previously approved these changes
Apr 14, 2025
Author
|
Is that commit related to this feature? |
Owner
|
The addition of the Gotify test case was a Codacy issue. The CI features and settings that I'm using are still in need of fine-tuning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted work from containrrr#2054.
If an API update includes a tag in its image filter, it will not be ignored, but it's still possible to provide a tagless image name.