Add start_index property to DigitalWaveform and NumericWaveform#194
Merged
mikeprosserni merged 3 commits intomainfrom Sep 10, 2025
Merged
Add start_index property to DigitalWaveform and NumericWaveform#194mikeprosserni merged 3 commits intomainfrom
mikeprosserni merged 3 commits intomainfrom
Conversation
Contributor
bkeryan
requested changes
Sep 9, 2025
bkeryan
approved these changes
Sep 10, 2025
csjall
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adds
DigitalWaveform.start_indexandNumericWaveform.start_indexas read-only properties.Why should this Pull Request be merged?
AB#3258929
What testing has been done?
Added and updated asserts in existing tests.