Skip to content

Changing unit description to units for consistency#177

Merged
hellovolcano merged 2 commits intomainfrom
users/vgleason/unit-description
Aug 20, 2025
Merged

Changing unit description to units for consistency#177
hellovolcano merged 2 commits intomainfrom
users/vgleason/unit-description

Conversation

@hellovolcano
Copy link
Copy Markdown
Contributor

What does this Pull Request accomplish?

Updates the instances of unit_description to units for consistency.

Why should this Pull Request be merged?

Fixes #168

What testing has been done?

Unit tests pass

Signed-off-by: Valerie Gleason 👌 <valerie.gleason@emerson.com>
Signed-off-by: Valerie Gleason 👌 <valerie.gleason@emerson.com>
@hellovolcano hellovolcano marked this pull request as ready for review August 19, 2025 20:32
@github-actions
Copy link
Copy Markdown
Contributor

Test Results

    44 files  ±0      44 suites  ±0   1h 29m 51s ⏱️ -22s
 2 197 tests ±0   2 197 ✅ ±0  0 💤 ±0  0 ❌ ±0 
49 875 runs  ±0  49 875 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1532be2. ± Comparison against base commit 764a576.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
tests.unit.waveform.test_analog_waveform ‑ test___invalid_type___set_unit_description___raises_type_error
tests.unit.waveform.test_analog_waveform ‑ test___waveform___set_unit_description___sets_extended_property
tests.unit.waveform.test_spectrum ‑ test___invalid_type___set_unit_description___raises_type_error
tests.unit.waveform.test_spectrum ‑ test___spectrum___set_unit_description___sets_extended_property
tests.unit.waveform.test_analog_waveform ‑ test___invalid_type___set_units___raises_type_error
tests.unit.waveform.test_analog_waveform ‑ test___waveform___set_units___sets_extended_property
tests.unit.waveform.test_spectrum ‑ test___invalid_type___set_units___raises_type_error
tests.unit.waveform.test_spectrum ‑ test___spectrum___set_units___sets_extended_property

@hellovolcano hellovolcano merged commit 4b16fe3 into main Aug 20, 2025
28 checks passed
@hellovolcano hellovolcano deleted the users/vgleason/unit-description branch August 20, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent naming: units vs unit_description

2 participants