Add setter for sample_count property#175
Merged
hellovolcano merged 10 commits intomainfrom Aug 20, 2025
Merged
Conversation
Signed-off-by: Valerie Gleason 👌 <[email protected]>
Signed-off-by: Valerie Gleason 👌 <[email protected]>
Contributor
bkeryan
requested changes
Aug 15, 2025
This reverts commit 4a9fc4a.
Signed-off-by: Valerie Gleason 👌 <[email protected]>
Signed-off-by: Valerie Gleason 👌 <[email protected]>
Signed-off-by: Valerie Gleason 👌 <[email protected]>
Signed-off-by: Valerie Gleason 👌 <[email protected]>
csjall
approved these changes
Aug 20, 2025
Signed-off-by: Valerie Gleason 👌 <[email protected]>
bkeryan
approved these changes
Aug 20, 2025
Collaborator
bkeryan
left a comment
bkeryan
left a comment
There was a problem hiding this comment.
This PR looks good but we should consider whether to make start_index writable in a follow-up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Why should this Pull Request be merged?
AB#3228924
What testing has been done?