Skip to content
This repository was archived by the owner on Sep 26, 2025. It is now read-only.

feat: replace custom C code with govips#196

Merged
dbarrosop merged 3 commits into
mainfrom
govips
Jan 26, 2024
Merged

feat: replace custom C code with govips#196
dbarrosop merged 3 commits into
mainfrom
govips

Conversation

@dbarrosop

@dbarrosop dbarrosop commented Jan 18, 2024

Copy link
Copy Markdown
Member

We initially wrote our own C code because our benchmarking showed govips used too much memory but now it seems to be the opposite. Their library is also better than our custom code and it should fix #194 and #180

@quentin-decre

Copy link
Copy Markdown

Thanks for having kept this issue in mind !

@dbarrosop dbarrosop self-assigned this Jan 23, 2024
@onehassan onehassan self-requested a review January 26, 2024 12:49
@dbarrosop dbarrosop merged commit c5c23f1 into main Jan 26, 2024
@dbarrosop dbarrosop deleted the govips branch January 26, 2024 12:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image orientation metadata lost when transformations applied

4 participants