forked from ggml-org/llama.cpp
-
Notifications
You must be signed in to change notification settings - Fork 4
Xsn/server sleep #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ngxson
wants to merge
14
commits into
master
Choose a base branch
from
xsn/server_sleep
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+355
−122
Open
Xsn/server sleep #62
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e1d7b43
implement sleeping at queue level
ngxson 197e578
implement server-context suspend
ngxson db3b78d
add test
ngxson aea8f8c
add docs
ngxson 44a5a26
optimization: add fast path
ngxson e6ab62c
make sure to free llama_init
ngxson 937b064
nits
ngxson 105e2f3
fix use-after-free
ngxson fd09f88
allow /models to be accessed during sleeping, fix use-after-free
ngxson 0bb9bc4
don't allow accessing /models during sleep, it is not thread-safe
ngxson d850082
fix data race on accessing props and model_meta
ngxson 1663d2f
small clean up
ngxson b51da9a
trailing whitespace
ngxson 06a5ebe
rm outdated comments
ngxson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential resource leak if destroyed while sleeping.
When the server is in sleeping state, the destructor skips calling
destroy(). However,destroy()also cleans up resources beyondllama_init, including:mctx(multimodal context)ctx_dft,spec)batchmemoryThese resources will leak if the server is destroyed while sleeping.
🔎 Proposed fix
~server_context_impl() { - if (!sleeping) { - destroy(); - } + destroy(); }And update
destroy()to be idempotent:void destroy() { + if (!llama_init && !mctx) { + return; // already destroyed + } llama_init.reset(); ctx = nullptr; model = nullptr; mtmd_free(mctx); mctx = nullptr; // ... rest of cleanup }📝 Committable suggestion
🤖 Prompt for AI Agents